Skip to content

Conversation

@engdoreis
Copy link
Contributor

The reduction is necessary due to increased bus capacitance introduced by external wires connected to the TPM SPI interface, which affects signal integrity. This change improves CW340 stability during bootstrap for CI tests.

Copy link
Contributor

@AlexJones0 AlexJones0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, it makes sense for the current CW340 CI setup. I wonder if you could add a comment so that anybody without external connections to the TPM wires knows that they can safely bump this back to 5000000 bps?

@AlexJones0
Copy link
Contributor

AlexJones0 commented Nov 21, 2025

Also maybe you should add the [opentitantool] prefix to the commit / PR title?

The reduction is necessary due to increased bus capacitance introduced by external wires connected
to the TPM SPI interface, which affects signal integrity.
This change improves CW340 stability during bootstrap for CI tests.

Signed-off-by: Douglas Reis <[email protected]>
@engdoreis engdoreis added the CherryPick:master This PR should be cherry-picked to master label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CherryPick:master This PR should be cherry-picked to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants